[
https://issues.apache.org/jira/browse/HADOOP-19223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864832#comment-17864832
]
ASF GitHub Bot commented on HADOOP-19223:
-----------------------------------------
slfan1989 commented on PR #6937:
URL: https://github.com/apache/hadoop/pull/6937#issuecomment-2221670104
> I like the -1 here. emphasises that tests are not an option and that
leaving out tests is a special case which needs active intervention
+1
I agree with Steve's opinion that we expect unit tests to be added when
submitting code. However, for tasks like upgrading jar dependencies or changing
shell scripts, it should be confirmed by the reviewer whether unit tests are
necessary.
> Don't fail CI if no tests are changed
> -------------------------------------
>
> Key: HADOOP-19223
> URL: https://issues.apache.org/jira/browse/HADOOP-19223
> Project: Hadoop Common
> Issue Type: Wish
> Reporter: Cheng Pan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
