anujmodi2021 commented on code in PR #6787:
URL: https://github.com/apache/hadoop/pull/6787#discussion_r1586020874
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java:
##########
@@ -552,16 +552,7 @@ protected void assumeValidAuthConfigsPresent() {
currentAuthType == AuthType.SAS);
if (currentAuthType == AuthType.SharedKey) {
assumeValidTestConfigPresent(getRawConfiguration(),
FS_AZURE_ACCOUNT_KEY);
- } else if (currentAuthType == AuthType.OAuth) {
Review Comment:
Removed code was to make sure that required configs to work with OAuth are
present. This was a redundant check as a similar check is already present in
AbfsConfiguration::getTokenProvider() method where these fields are parsed as
Mandatory fields. getMandatoryPasswordField will take care of throwing relevant
exception in case these are not configured.
Moreover the redundant check was working only for Client-Secret Token
Provider and not for other OAuth Token Providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
