saxenapranav commented on code in PR #6676:
URL: https://github.com/apache/hadoop/pull/6676#discussion_r1552980351
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsStreamStatistics.java:
##########
@@ -136,10 +136,10 @@ public void testAbfsStreamOps() throws Exception {
}
if
(fs.getAbfsStore().isAppendBlobKey(fs.makeQualified(largeOperationsFile).toString()))
{
- // for appendblob data is already flushed, so there is more data to
read.
+ // for appendblob data is already flushed, so there might be more data
to read.
assertTrue(String.format("The actual value of %d was not equal to the "
+ "expected value", statistics.getReadOps()),
- statistics.getReadOps() == (largeValue + 3) ||
statistics.getReadOps() == (largeValue + 4));
+ statistics.getReadOps() >= largeValue || statistics.getReadOps() <=
(largeValue + 4));
Review Comment:
what is reason of these condition changing.
##########
hadoop-tools/hadoop-azure/dev-support/testrun-scripts/testsupport.sh:
##########
@@ -21,8 +21,13 @@ combtestfile=$resourceDir
combtestfile+=abfs-combination-test-configs.xml
logdir=dev-support/testlogs/
-testresultsregex="Results:(\n|.)*?Tests run:"
+testresultsregex="Tests run: [0-9]+, Failures: [0-9]+, Errors: [0-9]+,
Skipped: [0-9]+$"
+failedTestRegex1="<<< FAILURE!$"
+failedTestRegex2="<<< ERROR!$"
+removeFormattingRegex="s/\x1b\[[0-9;]*m//g"
Review Comment:
Lets add a comment to explain what regex do.
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java:
##########
@@ -532,4 +528,36 @@ protected long assertAbfsStatistics(AbfsStatistic
statistic,
(long) metricMap.get(statistic.getStatName()));
return expectedValue;
}
+
+ protected void assumeValidTestConfigPresent(final Configuration conf, final
String key) {
+ String configuredValue = conf.get(key);
Review Comment:
it should also check conf.get(key.<accountUrl>, as done in
`AbfsConfiguration.accountConf(name)`. All the configs are checked on both key
and key.<accountUrl>. Dev can give anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
