[ 
https://issues.apache.org/jira/browse/HADOOP-18135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833283#comment-17833283
 ] 

ASF GitHub Bot commented on HADOOP-18135:
-----------------------------------------

ayushtkn commented on code in PR #6673:
URL: https://github.com/apache/hadoop/pull/6673#discussion_r1548383924


##########
hadoop-common-project/hadoop-common/pom.xml:
##########
@@ -1093,8 +1093,9 @@
                         <goal>exec</goal>
                     </goals>
                     <configuration>
-                        
<executable>${basedir}/../../dev-support/bin/releasedocmaker</executable>
+                        <executable>${shell-executable}</executable>

Review Comment:
   the default value is there in the hadoop-main pom.xml
   https://github.com/apache/hadoop/blob/trunk/pom.xml#L123
   
   the value is bash by default, for windows it needs to be overridden by some 
diff value as per Building.txt





> Produce Windows binaries of Hadoop
> ----------------------------------
>
>                 Key: HADOOP-18135
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18135
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.4.0
>         Environment: Windows 10
>            Reporter: Gautham Banasandra
>            Assignee: Gautham Banasandra
>            Priority: Major
>              Labels: pull-request-available
>
> We currently only provide Linux libraries and binaries. We need to provide 
> the same for Windows. We need to port the [create-release 
> script|https://github.com/apache/hadoop/blob/5f9932acc4fa2b36a3005e587637c53f2da1618d/dev-support/bin/create-release]
>  to run on Windows and produce the Windows binaries.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to