goiri commented on code in PR #6655:
URL: https://github.com/apache/hadoop/pull/6655#discussion_r1546976890
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/resolver/TestNamenodeResolver.java:
##########
@@ -359,11 +359,12 @@ public void testRegistrationNamenodeSelection()
FederationNamenodeServiceState.ACTIVE);
// 1) ns0:nn0 - Standby (oldest)
- // 2) ns0:nn1 - Standby (newest)
- // 3) ns0:nn2 - Standby
- // Verify the selected entry is the newest standby entry
+ // 2) ns0:nn1 - Standby
+ // 3) ns0:nn2 - Standby (newest)
+ // Verify the selected entry is the oldest standby entry
assertTrue(namenodeResolver.registerNamenode(createNamenodeReport(
NAMESERVICES[0], NAMENODES[0], HAServiceState.STANDBY)));
+ Thread.sleep(1500);
Review Comment:
We shouldn't be adding waits like this, can we add a
GenericTestUtils#waitFor or similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
