[
https://issues.apache.org/jira/browse/HADOOP-19093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824020#comment-17824020
]
ASF GitHub Bot commented on HADOOP-19093:
-----------------------------------------
steveloughran commented on code in PR #6596:
URL: https://github.com/apache/hadoop/pull/6596#discussion_r1514542657
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/TaskPool.java:
##########
@@ -545,7 +545,8 @@ private void resetStatisticsContext() {
* @param futures futures.
* @param sleepInterval Interval in milliseconds to await completion.
*/
- private static void waitFor(Collection<Future<?>> futures, int
sleepInterval) {
+ @InterfaceAudience.Private
+ public static void waitFor(Collection<Future<?>> futures, int sleepInterval)
{
Review Comment:
or move to FutureIO and cross reference from here. The cleaner solution
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java:
##########
@@ -489,6 +489,7 @@ protected Path getUniquePath(String filepath) {
.right(UUID.randomUUID().toString(), SHORTENED_GUID_LEN));
}
+
Review Comment:
cut
> add load tests for abfs rename resilience
> -----------------------------------------
>
> Key: HADOOP-19093
> URL: https://issues.apache.org/jira/browse/HADOOP-19093
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure, test
> Affects Versions: 3.3.6
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> I need a load test to verify that the rename resilience of the manifest
> committer actually works as intended
> * test suite with name ILoadTest* prefix (as with s3)
> * parallel test running with many threads doing many renames
> * verify that rename recovery should be detected
> * and that all renames MUST NOT fail.
> maybe also: metrics for this in fs and doc update.
> Possibly; LogExactlyOnce to warn of load issues
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
