shahrs87 commented on code in PR #6566:
URL: https://github.com/apache/hadoop/pull/6566#discussion_r1511445056
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java:
##########
@@ -1817,10 +1839,10 @@ protected LocatedBlock nextBlockOutputStream() throws
IOException {
nodes = lb.getLocations();
nextStorageTypes = lb.getStorageTypes();
nextStorageIDs = lb.getStorageIDs();
-
+ setPipeline(lb);
// Connect to first DataNode in the list.
success = createBlockOutputStream(nodes, nextStorageTypes,
nextStorageIDs,
- 0L, false);
+ 0L, false) || setupPipelineForAppendOrRecovery();
Review Comment:
> If I catch it right, it is a behaviour change, right?
I agree this is a behavior change but the current behavior is buggy.
`dtpReplaceDatanodeOnFailureReplication` configuration is NOT honored during
the `PIPELINE_SETUP_CREATE` phase. Thats why this jira was created.
After this patch, we will handle datanode failure during
`PIPELINE_SETUP_CREATE` in the same way as `DATA_STREAMING` phase and the
application (in this case hbase) will experience consistent behavior using hdfs
client.
Cc @ritegarg @ayushtkn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
