saxenapranav commented on code in PR #6592:
URL: https://github.com/apache/hadoop/pull/6592#discussion_r1502450811
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemAttributes.java:
##########
@@ -91,13 +90,6 @@ public void testSetGetXAttrReplace() throws Exception {
.containsExactly(attributeValue2);
}
- @Test
- public void testGetSetXAttrOnRoot() throws Exception {
- AzureBlobFileSystem fs = getFileSystem();
- final Path testPath = new Path("/");
- testGetSetXAttrHelper(fs, testPath);
Review Comment:
To prevent revert add of getFileSystemProperties and setFileSystemProperties
for getXAttr / setXAttr in future, should we not remove this method, and
additionally assert that the getFileSystemProperties and
setFileSystemProperties of store are not called.
##########
hadoop-tools/hadoop-azure/src/site/markdown/abfs.md:
##########
@@ -1229,6 +1229,11 @@ The fix is to mimic the ownership to the local OS user,
by adding the below prop
Once the above properties are configured, `hdfs dfs -ls
abfs://[email protected]/` shows the ADLS Gen2
files/directories are now owned by 'user1'.
+## <a name="KnownIssues"></a> Known Issues
+
+Following failures are known and expected to fail as of now.
+1. AzureBlobFileSystem.setXAttr() and AzureBlobFileSystem.getXAttr() will fail
when attempted on root ("/") path.
Review Comment:
Lets add reason for the failure as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
