steveloughran commented on code in PR #6406: URL: https://github.com/apache/hadoop/pull/6406#discussion_r1474321398
########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/aws_sdk_upgrade.md: ########## @@ -66,6 +66,25 @@ The change in interface will mean that custom credential providers will need to implement `software.amazon.awssdk.auth.credentials.AwsCredentialsProvider` instead of `com.amazonaws.auth.AWSCredentialsProvider`. +[HADOOP-18980](https://issues.apache.org/jira/browse/HADOOP-18980) introduces extended version of +the credential provider remapping. `fs.s3a.aws.credentials.provider.mapping` can be used to +list comma-separated key-value pairs of mapped credential providers that are separated by +equal operator (=). The key can be used by `fs.s3a.aws.credentials.provider` config, and it +will be translated into the specified value of credential provider class based on the key-value +pair provided by this config. + +For example, if `fs.s3a.aws.credentials.provider.mapping` is set with value: + Review Comment: nit: prefer triple backslash over indentation as it allows for us to specify the format. now: should we actually include this as an XML snippet or not? I'm of mixed feelings here. ########## hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/aws_sdk_upgrade.md: ########## @@ -66,6 +66,25 @@ The change in interface will mean that custom credential providers will need to implement `software.amazon.awssdk.auth.credentials.AwsCredentialsProvider` instead of `com.amazonaws.auth.AWSCredentialsProvider`. +[HADOOP-18980](https://issues.apache.org/jira/browse/HADOOP-18980) introduces extended version of +the credential provider remapping. `fs.s3a.aws.credentials.provider.mapping` can be used to +list comma-separated key-value pairs of mapped credential providers that are separated by +equal operator (=). The key can be used by `fs.s3a.aws.credentials.provider` config, and it +will be translated into the specified value of credential provider class based on the key-value +pair provided by this config. + +For example, if `fs.s3a.aws.credentials.provider.mapping` is set with value: + + com.amazonaws.auth.AnonymousAWSCredentials=org.apache.hadoop.fs.s3a.AnonymousAWSCredentialsProvider, + com.amazonaws.auth.EC2ContainerCredentialsProviderWrapper=org.apache.hadoop.fs.s3a.auth.IAMInstanceCredentialsProvider, + com.amazonaws.auth.InstanceProfileCredentialsProvider=org.apache.hadoop.fs.s3a.auth.IAMInstanceCredentialsProvider + +With the above key-value pairs, if `fs.s3a.aws.credentials.provider` specifies +`com.amazonaws.auth.AnonymousAWSCredentials`, it will be remapped to +`org.apache.hadoop.fs.s3a.AnonymousAWSCredentialsProvider` by S3A while preparing +AWS credential provider list. Review Comment: nit: "the AWS credential provider list" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
