Hisoka-X commented on code in PR #6488:
URL: https://github.com/apache/hadoop/pull/6488#discussion_r1470514489
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:
##########
@@ -4077,6 +4077,7 @@ private interface StatisticsAggregator<T> {
STATS_DATA_CLEANER.
setName(StatisticsDataReferenceCleaner.class.getName());
STATS_DATA_CLEANER.setDaemon(true);
+ STATS_DATA_CLEANER.setContextClassLoader(null);
Review Comment:
If the thread relies on the return value of
`Thread.currentThread().getContextClassLoader()` for logical processing, it may
encounter NPE, but I checked the corresponding code. This risk should not
exist. In fact, this is a normal way of handling classloader references in the
daemon thread. You can refer
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-7008595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
