[
https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807673#comment-17807673
]
ASF GitHub Bot commented on HADOOP-16822:
-----------------------------------------
pan3793 opened a new pull request, #6458:
URL: https://github.com/apache/hadoop/pull/6458
This reverts commit 2c4ab72a60113e4dd4ef2375e6f9413e519b1044.
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
TL;DR, it generate the wrong source code and messes the code jump in IDEA.
See details in https://issues.apache.org/jira/browse/HADOOP-16822
### How was this patch tested?
Pass CI.
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
> Provide source artifacts for hadoop-client-api
> ----------------------------------------------
>
> Key: HADOOP-16822
> URL: https://issues.apache.org/jira/browse/HADOOP-16822
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Karel Kolman
> Assignee: Karel Kolman
> Priority: Major
> Fix For: 3.3.1, 3.4.0, 3.2.3
>
> Attachments: HADOOP-16822-hadoop-client-api-source-jar.patch
>
>
> h5. Improvement request
> The third-party libraries shading hadoop-client-api (& hadoop-client-runtime)
> artifacts are super useful.
>
> Having uber source jar for hadoop-client-api (maybe even
> hadoop-client-runtime) would be great for downstream development & debugging
> purposes.
> Are there any obstacles or objections against providing fat jar with all the
> hadoop client api as well ?
> h5. Dev links
> - *maven-shaded-plugin* and its *shadeSourcesContent* attribute
> -
> https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#shadeSourcesContent
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]