goiri commented on code in PR #6312:
URL: https://github.com/apache/hadoop/pull/6312#discussion_r1414412936


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterTrash.java:
##########
@@ -282,6 +282,13 @@ public void testMultipleMountPoint() throws IOException,
     fileStatuses = fs.listStatus(new Path("/user/test-trash/.Trash/Current/" + 
MOUNT_POINT2));
     assertEquals(0, fileStatuses.length);
 
+    // In ns1, make a trash path with timestamp to simulate a trash path.
+    String trashPath = "/user/test-trash/.Trash/" + System.currentTimeMillis();
+    client1.mkdirs(trashPath, new FsPermission("770"),
+        true);
+    fileStatuses = fs.listStatus(new Path("/user/test-trash/.Trash"));

Review Comment:
   Can we make the tests a little more exhaustive?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to