[
https://issues.apache.org/jira/browse/HADOOP-18965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784501#comment-17784501
]
ASF GitHub Bot commented on HADOOP-18965:
-----------------------------------------
ahmarsuhail commented on code in PR #6261:
URL: https://github.com/apache/hadoop/pull/6261#discussion_r1388132245
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ITestS3AHugeFilesEncryption.java:
##########
@@ -68,13 +70,16 @@ protected boolean isEncrypted(S3AFileSystem fileSystem) {
@Override
protected void assertEncrypted(Path hugeFile) throws IOException {
Configuration c = new Configuration();
- String kmsKey = getS3EncryptionKey(getTestBucketName(c), c);
- if (SSE_KMS.getMethod().equals(c.get(S3_ENCRYPTION_ALGORITHM))) {
+
+ final String bucket = getTestBucketName(c);
+ String kmsKey = getS3EncryptionKey(bucket, c);
Review Comment:
nit: consider changing variable name from c to conf
> ITestS3AHugeFilesEncryption failure
> -----------------------------------
>
> Key: HADOOP-18965
> URL: https://issues.apache.org/jira/browse/HADOOP-18965
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> test failures for me with a test setup of per-bucket encryption of sse-kms.
> suspect (but can't guarantee) HADOOP-18850 may be a factor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
