ayushtkn commented on code in PR #6136:
URL: https://github.com/apache/hadoop/pull/6136#discussion_r1342622365
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Quota.java:
##########
@@ -75,8 +75,10 @@ public Quota(Router router, RouterRpcServer server) {
* @param storagespaceQuota Storage space quota.
* @param type StorageType that the space quota is intended to be set on.
* @param checkMountEntry whether to check the path is a mount entry.
- * @throws AccessControlException If the quota system is disabled or if
+ * @throws IOException If the quota system is disabled or if
* checkMountEntry is true and the path is a mount entry.
+ * By the way, this latter case actually throws an AccessControlException,
+ * which happens to be a subclass of IOException.
Review Comment:
Correcting that throws to IOE is ok, this Bu the way line isn’t required
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/Quota.java:
##########
@@ -75,8 +75,10 @@ public Quota(Router router, RouterRpcServer server) {
* @param storagespaceQuota Storage space quota.
* @param type StorageType that the space quota is intended to be set on.
* @param checkMountEntry whether to check the path is a mount entry.
- * @throws AccessControlException If the quota system is disabled or if
+ * @throws IOException If the quota system is disabled or if
* checkMountEntry is true and the path is a mount entry.
+ * By the way, this latter case actually throws an AccessControlException,
+ * which happens to be a subclass of IOException.
Review Comment:
Correcting that throws to IOE is ok, this Bu the way line isn’t required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
