Looks like no one objects removing CentOS 7 support for trunk (3.5), do we need a VOTE to move this forward?
Thanks, Cheng Pan On 2025/03/18 05:18:28 Istvan Toth wrote: > Thanks Steve. > > I agree that it's time to move off Java 8. > > The *trunk* and *branch-3.4* CIs are still broken because of the original > issue, so there is also a short-term problem that needs to be fixed. > If we're not ready to drop Centos7 from CI right now, my PR > <https://github.com/apache/hadoop/pull/7499> would fix both branches. > > Istvan > > On Fri, Mar 14, 2025 at 2:14 PM Steve Loughran <ste...@cloudera.com> wrote: > > > > > I think we really need to push ahead on a 3.5 release for this stuff and > > for java 17. > > > > I'm doing the new thirdparty jar once I've got the docker building *and > > signing* it...I'm having to do the build in EC2 as it doesn't seem to work > > on my arm64 laptop right now. > > > > Then ahmar can start the 3.4.2 release > > > > Maybe we can consider 3.4.x feature complete and work on getting 3.5 out > > the door? > > > > > > > > On Thu, 13 Mar 2025 at 06:37, Istvan Toth <st...@apache.org> wrote: > > > >> Thanks everyone for contributing. > >> > >> To summarize the discussion on YARN-11794: We can fix the build on 3.4 by > >> using an older plugin binary (which does not have any changes related to > >> the generated code compared to the current one), or by committing the > >> generated Java code. > >> Shilun Fan and I prefer the former (that's what my PR does), while > >> @cheng...@apache.org <cheng...@apache.org> prefers the latter (my > >> interpretation). > >> (We can probably also rebuild the plugin from source, and use that) > >> > >> Fixing the issue either way will let us keep Centos 7 builds working > >> branch-3.4. > >> > >> Since we are on the topic, Debian 10 has also reached EOL in June 2024, I > >> propose dropping build support for that one in 3.5, too. > >> (I have not checked, but I wouldn't be surprised if Debian 10 had the same > >> issues as Centos 7) > >> > >> Dropping build support for EOL distros before the 3.5 release would save a > >> lot of pain like this down the line. > >> > >> If maintaining runtime support for EOL distros for 3.5 is important, then > >> the best way would be adding tests to CI specifically for testing the > >> binary > >> components in the official assembly (built on the image that the binary > >> releases use) on an old docker image. (Though this is quite a bit of work) > >> > >> IMO ideally Debian 12, Ubuntu 24.04 and RHEL/Alma/Rocky 9 build images and > >> build support should be added for 3.5., and Windows should also be updated > >> to 11. > >> This is not a small task, but I think that a new release should support > >> building on current distros. (Unfortunately I do not have the time to work > >> on that) > >> > >> Istvan > >> > >> > >> On Wed, Mar 12, 2025 at 3:03 PM Cheng Pan <pan3...@gmail.com> wrote: > >> > >> > Istvan, thank you for working on restoring build support on CentOS 7 on > >> > branch-3.4, let’s keep the high level discussion on the mailing list and > >> > implementation details on the PR directly. > >> > > >> > Thanks, > >> > Cheng Pan > >> > > >> > > >> > > >> > On Mar 12, 2025, at 16:47, Istvan Toth <st...@apache.org> wrote: > >> > > >> > "Support for any OS SHOULD NOT be dropped without first being documented > >> > as deprecated for a full major release and MUST NOT be dropped without > >> > first being deprecated for at least a full minor release." > >> > > >> > I am not aware of any distro being explicitly deprecated by Hadoop, I > >> > don't think that the intent was for OS to be interpreted as distro. > >> > Especially the major release suggestion would be absurd, as it > >> > would suggest supporting distros for 15+ years. > >> > > >> > I've submitted a PR for reverting the plugin version in 3.4, but I still > >> > think that build support for Centos 7 should be dropped for 3.5. > >> > https://github.com/apache/hadoop/pull/7499 > >> > > >> > BTW the Centos 7 Docker image cannot even be built on 3.4, and no-one > >> has > >> > complained in several months (it was only fixed on trunk) > >> > > >> > Istvan > >> > > >> > > >> > On Wed, Mar 12, 2025 at 12:17 AM Chris Nauroth <cnaur...@apache.org> > >> > wrote: > >> > > >> >> I'm adding Cheng Pan, who expressed concerns here: > >> >> > >> >> https://github.com/apache/hadoop/pull/7493#issuecomment-2710815286 > >> >> > >> >> Cheng, this is a build time issue. If it doesn't impact runtime, then > >> is > >> >> it still a problem for you? I can imagine it might still be an impact > >> if > >> >> you need to make a custom patched build from source. > >> >> > >> >> We do have some prior established policies for this sort of thing: > >> >> > >> >> > >> >> > >> https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/Compatibility.html#Hardware.2FSoftware_Requirements > >> >> > >> >> "Support for any OS SHOULD NOT be dropped without first being > >> documented > >> >> as deprecated for a full major release and MUST NOT be dropped without > >> >> first being deprecated for at least a full minor release." > >> >> > >> >> There is nothing in the phrasing about specific Linux distros, but I > >> >> think if we were to follow the strictest interpretation, then the 3.4 > >> >> release line would continue to work for the same OS distros. > >> >> > >> >> I understand the other way forward is to look for a gRPC compiler > >> version > >> >> that works on CentOS 7 and is also compatible with the Netty upgrade. > >> Has > >> >> there been any investigation into that? > >> >> > >> >> Chris Nauroth > >> >> > >> >> > >> >> On Mon, Mar 10, 2025 at 9:54 PM Istvan Toth <st...@apache.org> wrote: > >> >> > >> >>> CC to d...@hadoop.apache.org > >> >>> > >> >>> On Tue, Mar 11, 2025 at 5:51 AM Istvan Toth <st...@apache.org> wrote: > >> >>> > >> >>> > Hi, > >> >>> > > >> >>> > As reported in YARN-11794 , building Hadoop on Centos 7 has been > >> broken > >> >>> > for some time, and I don't see an easy way to fix it. > >> >>> > > >> >>> > I propose removing Centos 7 from the supported build platforms, and > >> >>> > removing the CentOs 7 precommit tests from Jenkins HADOOP-19489 . > >> >>> > > >> >>> > Note that this is a build isse, this does not affect running Hadoop > >> >>> > on CentOS. > >> >>> > > >> >>> > Istvan > >> >>> > > >> >>> > >> >> > >> > > >> > > > --------------------------------------------------------------------- To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-dev-h...@hadoop.apache.org