Thanks Ayush. Yeah, it seems like the 6 hours limitation is going to be an issue.Let me pursue the precommit CI setup for Windows 10 for now.
Thanks, --Gautham On Wed, 10 May 2023 at 04:53, Ayush Saxena <ayush...@gmail.com> wrote: > One thing I forgot to mention. If you are planning to run tests also for > Windows OS then github actions isn’t something to be chased. It has 6 hrs > timeout. > > So, in case of multi module changes or root level changes, we will get > screwed, the tests take more than 20 hrs in those cases, so we will hit the > timeout > > -Ayush > > On Tue, 9 May 2023 at 11:49 PM, Ayush Saxena <ayush...@gmail.com> wrote: > > > Hi Gautham, > > The only advantage I can think of is your limitation to nodes shouldn’t > > bother much. Though there are limited resources given to Apache but still > > never observed any starvation in any project for the resources using > Github > > Actions. > > > > If Precommit CI for windows is there and it can work in parallel, that > > should be good as well > > > > Good Luck!!! > > > > -Ayush > > > > On Tue, 9 May 2023 at 8:47 PM, Gautham Banasandra <gaur...@apache.org> > > wrote: > > > >> Hi Ayush, > >> > >> I was planning to set up the precommit CI job for Windows 10, so that > >> we validate each PR against Windows 10. The precommit CI can actually > >> run in parallel to the Linux precommit CI. But I think we've got very > few > >> Windows nodes (about 12 I think) compared to the number of Linux nodes > >> (about 40 in number). > >> However, I think the setting up the precommit CI is quite worth > >> the effort. > >> It was quite hard to get to this point and we certainly don't want to > >> regress > >> in this regard. I think I'll pursue this once I stabilize the nightly CI > >> and after > >> I sort out the rest of the failing parts (mvnsite, javadoc etc). > >> > >> Also, does Github Actions provide any advantage over precommit CI? > >> > >> Thanks, > >> --Gautham > >> > >> On Tue, 9 May 2023 at 02:44, Ayush Saxena <ayush...@gmail.com> wrote: > >> > >>> Awesome!!! > >>> > >>> Do you plan to run some builds per PR to ensure no commits breaks it > >>> in the future? Worth exploring GithubActions in the later stages if we > >>> can have an action for maven install on windows, it won't affect the > >>> normal build time as well. can run in parallel with the existing > >>> builds. > >>> > >>> -Ayush > >>> > >>> On Mon, 8 May 2023 at 23:39, Gautham Banasandra <gaur...@apache.org> > >>> wrote: > >>> > > >>> > Dear Hadoop community, > >>> > > >>> > It is my pleasure to announce that I've set up the Nightly Jenkins CI > >>> for > >>> > Hadoop on the Windows 10 platform[1]. The effort mainly involved > >>> getting > >>> > Yetus to run on Windows against Hadoop. > >>> > The nightly CI will run every 36 hours and send out the build report > >>> to the > >>> > same recipients as this email, upon completion. > >>> > There are still quite a few things that need to be sorted out. > >>> Currently, > >>> > mvninstall has a +1. Other phases like mvnsite, javadoc etc still > need > >>> to be > >>> > fixed. > >>> > > >>> > [1] > >>> > > >>> > https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-win10-x86_64/ > >>> > > >>> > Thanks, > >>> > --Gautham > >>> > >> >
