Viraj Jasani created HADOOP-18006:
-------------------------------------
Summary: maven-enforcer-plugin's execution of
banned-illegal-imports gets overridden in child poms
Key: HADOOP-18006
URL: https://issues.apache.org/jira/browse/HADOOP-18006
Project: Hadoop Common
Issue Type: Bug
Reporter: Viraj Jasani
Assignee: Viraj Jasani
When we specify any maven plugin with execution tag in the parent as well as
child modules, child module plugin overrides parent plugin. For instance, when
{{banned-illegal-imports}} is applied for any child module with only one banned
import (let’s say {{{}Preconditions{}}}), then only that banned import is
covered by that child module and all imports defined in parent module (e.g
Sets, Lists etc) are overridden and they are no longer applied.
After this
[commit|https://github.com/apache/hadoop/commit/62c86eaa0e539a4307ca794e0fcd502a77ebceb8],
hadoop-hdfs module will not complain about {{Sets}} even if i import it from
guava banned imports but on the other hand, hadoop-yarn module doesn’t have any
child level {{banned-illegal-imports}} defined so yarn modules will fail if
{{Sets}} guava import is used.
So going forward, it would be good to replace guava imports with Hadoop’s own
imports module-by-module and only at the end, we should add new entry to parent
pom {{banned-illegal-imports}} list.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
