Cool, thanks! On Thu, Jan 3, 2019 at 6:28 PM Steve Loughran <ste...@hortonworks.com> wrote:
> > > > On 3 Jan 2019, at 01:22, lqjacklee <lqjack...@gmail.com> wrote: > > > > Thanks Steve, I like the style PR from the GitHub. when should we start > to > > change it ? > > > Step 1 is having Yetus review github PRs associated with a JIRA. Without > that part of the process, we can't begin to use github for reviewing. > > For a long time we were on yetus 0.5.0, which I believe lagged here. But > since september, Hadoop has been on Yetus 0.8.0 -the latest release > (HADOOP-14761). If there's more in there for github PR review we should > enable it. And if we need more, well, its an ASF project: we all have the > right to submit patches there too, the duty to test them first > > -steve > > > > > > On Thu, Jan 3, 2019 at 7:07 AM Steve Loughran <ste...@hortonworks.com> > > wrote: > > > >> > >> The new gitbox repo apparently does 2 way linking from github: you can > >> commit a PR there and it'll make its way back > >> > >> this could be really slick -and do a big change to our review process. > >> > >> Before we can go near it though, we need to get Yetus doing its review & > >> test of github PRs, which is not working right now > >> > >> What will it take to do that? And that means not "what does AW have to > >> do", but "how can we help get this done?" > >> > >> -steve > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: common-dev-unsubscr...@hadoop.apache.org > >> For additional commands, e-mail: common-dev-h...@hadoop.apache.org > >> > >> > >
