[ https://issues.apache.org/jira/browse/HADOOP-6918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Allen Wittenauer resolved HADOOP-6918. -------------------------------------- Resolution: Fixed >From comments, this appears to be fixed in 2.x, so closing. > Make metrics naming consistent > ------------------------------ > > Key: HADOOP-6918 > URL: https://issues.apache.org/jira/browse/HADOOP-6918 > Project: Hadoop Common > Issue Type: Improvement > Components: metrics > Affects Versions: 0.20.2, 0.21.0 > Reporter: Luke Lu > Assignee: Luke Lu > > While working HADOOP-6728, I noticed that our metrics naming style is all > over the place: > * Capitalized camel case: e.g., "FilesCreated" in namenode metrics and some > rpc metrics > * uncapitalized camel case: e.g, "threadsBlocked" in jvm metrics and some rpc > metrics > * lowercased underscored: e.g., "bytes_written" in datanode metrics and > mapreduce metrics > Let's make them consistent. How about uncapitalized camel case? My main > reason for the camel case: some backends have limits on the name length and > underscore is wasteful. > Once we have a consistent naming style we can do: > @Metric("Number of INodes created") MutableCounterLong filesCreated; > instead of the more redundant: > @Metric({"FilesCreated", "Number of INodes created"}) MutableCounterLong > filesCreated; -- This message was sent by Atlassian JIRA (v6.2#6252)