[
https://issues.apache.org/jira/browse/HADOOP-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth resolved HADOOP-10576.
------------------------------------
Resolution: Not a Problem
Hi, [~swarnim]. When our Jenkins server runs pre-commit builds on new patches,
it runs findbugs on current trunk, then repeats running findbugs on the patched
code, and then compares before and after. If the number of findbugs warnings
is higher after the patch, then Jenkins comments on the jira with a -1. In
most cases, this means the contributor then has responsibility to upload a new
version of the patch that fixes the findbugs warnings. The code for this is in
dev-support/test-patch.sh, in the function {{checkFindbugsWarnings}}.
The reason for HADOOP-10477 and related issues is that we're upgrading the
findbugs version that we use. The new version is able to identify a greater
number of bugs. The clean-up issues are fixing the new warnings that we're
seeing after upgrading the toolchain, not reacting to technical debt that has
accumulated over time.
I think this covers what you were requesting in this issue, so I'm resolving it
as Not a Problem. If I misunderstood, please feel free to reopen it and add
more details.
> Fail build on new findbugs warnings
> -----------------------------------
>
> Key: HADOOP-10576
> URL: https://issues.apache.org/jira/browse/HADOOP-10576
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Swarnim Kulkarni
> Assignee: Swarnim Kulkarni
>
> Issues like HADOOP-10477 seem like an unnecessary technical debt for
> developers I think which can be easily fixed by simply failing the build
> anytime a code change introduces a new findbugs warning. This might help keep
> the code base cleaner and avoid us going back to fix those warnings.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
