Hi Karthik, I submitted the patch to https://issues.apache.org/jira/browse/MAPREDUCE-5748
I followed http://wiki.apache.org/hadoop/HowToContribute Thank you. Best, Hussein. On Wed, Mar 19, 2014 at 9:33 PM, Karthik Kambatla <ka...@cloudera.com>wrote: > Hey Hussein > > Thanks for picking MAPREDUCE-5748 up. Can you post the patch on the JIRA, > and we can continue the conversation there? > > Thanks > Karthik > > > On Wed, Mar 19, 2014 at 12:55 PM, Hussein Baghdadi <hubaghd...@gmail.com > >wrote: > > > Hi, > > > > I tried to fix MAPREDUCE-5748 > > > > What I did is to add another condition in addition to checking for nulls. > > I'm checking whether mapIds is empty or not > > > > if (mapIds == null || mapIds.size() == 0 || reduceQ == null || jobQ == > > null) > > > > I also created a unit test where 'map' param is missing. I'm not sure > > about the quality of the unit test but I tried my best. > > > > Here in the email, you can find a patch file. > > > > Thanks for help and time. > > > > Best, > > Hussein. > > > > -- > > > > *Deep into that darkness peering, long I stood there, wondering, fearing, > > doubting, dreaming dreams no mortal ever dared to dream before. Edgar > Allan > > Poe* > > > -- *Deep into that darkness peering, long I stood there, wondering, fearing, doubting, dreaming dreams no mortal ever dared to dream before.Edgar Allan Poe*
