Hi Aaron, Didn't see a JIRA for the findbugs issues, so I made one and provided a patch:
https://issues.apache.org/jira/browse/HADOOP-7833 There is a JIRA for the javadoc warnings: https://issues.apache.org/jira/browse/HADOOP-6830 There has not been any activity on it since being reported. I'll see if I can provide a patch for it. John On Thu, Nov 17, 2011 at 1:33 PM, Aaron T. Myers <a...@cloudera.com> wrote: > Hi John, > > There may be a JIRA filed already to address those particular warnings, but > I'm not aware of it if there is one. If you'd like to file that JIRA and > provide a patch to fix it (most likely just by making test-patch ignore > those warnings) I would be happy to review/commit it. > > -- > Aaron T. Myers > Software Engineer, Cloudera > > > > On Thu, Nov 17, 2011 at 10:20 AM, John Lee <j...@meebo-inc.com> wrote: > >> Hi Aaron, >> >> Thanks for advice, do you know if there are plans to eliminate the >> warning messages from findbugs and javadoc? >> The findbugs warnings are related to protocal buffer code and the >> javadoc warnings are "Sun proprietary API and may be removed in a >> future release" code. >> >> John >> >> On Thu, Nov 17, 2011 at 1:00 PM, Aaron T. Myers <a...@cloudera.com> wrote: >> > Hi John, >> > >> > If you're confident that the warnings are unrelated to the patch, just >> > comment saying so on that JIRA and that will be fine. >> > >> > -- >> > Aaron T. Myers >> > Software Engineer, Cloudera >> > >> > >> > >> > On Thu, Nov 17, 2011 at 8:58 AM, John Lee <j...@meebo-inc.com> wrote: >> > >> >> I recently resubmitted a patch for >> >> https://issues.apache.org/jira/browse/HADOOP-7021 and received -1 >> >> overall. When I took a look at what was the cause and it was due to >> >> some findbugs warnings and javadoc warnings, which were unrelated to >> >> the patch. Do these warnings need to be resolved before any new code >> >> is committed to Hadoop Common? >> >> >> > >> >
