----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/270/#review102 -----------------------------------------------------------
trunk/src/java/org/apache/hadoop/security/SaslRpcServer.java <https://reviews.apache.org/r/270/#comment196> rather than duplicating the defaults here, can you just call setConfiguration(new HadoopConfiguration())? Also, would this default ever get used? ie isn't setConfiguration() always going to get called by UGI's initialization code before it's used? trunk/src/test/core/org/apache/hadoop/ipc/TestSaslRPC.java <https://reviews.apache.org/r/270/#comment197> could you comment on this test change? - Todd On 2011-01-10 12:08:47, Todd Lipcon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/270/ > ----------------------------------------------------------- > > (Updated 2011-01-10 12:08:47) > > > Review request for hadoop-common and Todd Lipcon. > > > Summary > ------- > > See JIRA - uploading Kan's patch for easier review. > > > This addresses bug HADOOP-6902. > https://issues.apache.org/jira/browse/HADOOP-6902 > > > Diffs > ----- > > trunk/src/java/org/apache/hadoop/ipc/RPC.java 992454 > trunk/src/java/org/apache/hadoop/ipc/Server.java 992454 > trunk/src/java/org/apache/hadoop/security/SaslRpcClient.java 992454 > trunk/src/java/org/apache/hadoop/security/SaslRpcServer.java 992454 > trunk/src/java/org/apache/hadoop/security/UserGroupInformation.java 992454 > trunk/src/test/core/org/apache/hadoop/ipc/TestSaslRPC.java 992454 > > Diff: https://reviews.apache.org/r/270/diff > > > Testing > ------- > > > Thanks, > > Todd > >
