Eli, Thanks for the heads up, I'll build from the command line and verify that this works. As far as these unit tests take a look at the project suggestions page for hadoop, this task has to do with taking all of the examples and creating junit tests to drive the examples, so essentially what I've done is to create a junit test suite that runs each of the examples as a separate junit test. What I wanted to know now is whether to create a separate ant target or leverage and add to one of the pre-existing ant test targets.
Regards Sent from my iPhone On Sep 5, 2010, at 2:27 PM, Eli Collins <e...@cloudera.com> wrote: > Hey Saikat, > > mapreduce trunk builds (ant jar) cleanly for me. If you're seeing a > compilation error with the plugin checkout the patch on > MAPREDUCE-1280. I'd try compiling via the command line to make sure > it's not an issue with your tree. > > Looks like there are already some of the examples being driven as > tests in src/test/mapred/org/apache/hadoop/examples. I'd start there > and see which ones are missing and add them. Good idea btw, thanks > for working on this. > > Thanks, > Eli > > On Sun, Sep 5, 2010 at 2:12 PM, Saikat Kanjilal <sxk1...@hotmail.com> wrote: >> Hi Eli, >> I brought the whole mapreduce project inside eclipse and have been synching >> it using the eclipse svn plugin. Yesterday after doing a sync inside >> Eclipse I ran the test-core which resulted in compilation errors in a set of >> classes. >> >> >> As far as adding the unit tests go I already read through that link that you >> sent before I started, what I am really wondering about is whether or not to >> create a brand new target or run these as part of the one of the existing >> test ant targets. These are junit style tests that drive all of the >> mapreduce examples. >> >> Let me know your thoughts. >> >> Sent from my iPhone >> >> On Sep 5, 2010, at 1:55 PM, Eli Collins <e...@cloudera.com> wrote: >> >>> Hey Saikat, >>> >>> Running ant test-core in mapreduce on trunk should pass (modulo a >>> handful of flaky tests). What failures are you seeing? >>> >>> Info on how to add unit tests: >>> >>> http://wiki.apache.org/hadoop/HowToDevelopUnitTests >>> >>> Thanks, >>> Eli >>> >>> On Sat, Sep 4, 2010 at 10:27 PM, Saikat Kanjilal <sxk1...@hotmail.com> >>> wrote: >>>> >>>> HI Folks,I am working on this jira task and had some additional >>>> questions:1) It seems that whenever I go to run the test or the test-core >>>> target on the mapreduce codebase they both fail, I did a fresh sync prior >>>> to running these targets today. Am I missing some other files that are >>>> necessary?2) If I want to add a target for compiling and running a junit >>>> test suite that runs all of the current mapreduce examples should I create >>>> a brand new target or try to hack the test target to also run this set of >>>> tests, is there a standard when introducing a new set of tests?Looking >>>> forward to getting some more help on the above.Regards >>>>> Date: Fri, 13 Aug 2010 01:19:15 -0400 >>>>> From: j...@apache.org >>>>> To: sxk1...@hotmail.com >>>>> Subject: [jira] Moved: (MAPREDUCE-2008) write Junit test cases that run >>>>> the Hadoop examples >>>>> >>>>> >>>>> [ >>>>> https://issues.apache.org/jira/browse/MAPREDUCE-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel >>>>> ] >>>>> >>>>> Amareshwari Sriramadasu moved HADOOP-6891 to MAPREDUCE-2008: >>>>> ------------------------------------------------------------ >>>>> >>>>> Project: Hadoop Map/Reduce (was: Hadoop Common) >>>>> Key: MAPREDUCE-2008 (was: HADOOP-6891) >>>>> Affects Version/s: 0.20.2 >>>>> (was: 0.20.2) >>>>> Fix Version/s: 0.22.0 >>>>> (was: 0.20.3) >>>>> Component/s: examples >>>>> test >>>>> (was: test) >>>>> >>>>>> write Junit test cases that run the Hadoop examples >>>>>> --------------------------------------------------- >>>>>> >>>>>> Key: MAPREDUCE-2008 >>>>>> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2008 >>>>>> Project: Hadoop Map/Reduce >>>>>> Issue Type: New Feature >>>>>> Components: examples, test >>>>>> Affects Versions: 0.20.2 >>>>>> Environment: N/A >>>>>> Reporter: Saikat Kanjilal >>>>>> Priority: Minor >>>>>> Fix For: 0.22.0 >>>>>> >>>>>> Original Estimate: 20h >>>>>> Remaining Estimate: 20h >>>>>> >>>>>> I will be adding junit test cases that run the hadoop examples, >>>>>> specifically I'll be adding a test suite that tests everything under the >>>>>> src/examples/org/apache/hadoop/examples package. Since this is my first >>>>>> contribution to the project I'll need some help to figure out how to >>>>>> submit this >>>>> >>>>> -- >>>>> This message is automatically generated by JIRA. >>>>> - >>>>> You can reply to this email to add a comment to the issue online. >>>>> >>>> >>> >> >