On a related note, any objections to use http://code.google.com/p/thread-weaver/ in our unit tests?
__Luke On Fri, May 7, 2010 at 4:35 PM, Todd Lipcon <t...@cloudera.com> wrote: > Hi Cos, > > This looks great, and I'm excited to have more ways of finding these tricky > bugs. Are there any examples of bugs found already by these techniques? > > The one concern I have about the proposal is with this: >> SureLogic analysis is going to be included to the test-patch process. This > said new patches are required not to raise SureLogic warnings level (similar > to the requirements about FindBugs or javac). > > This is slightly worrisome since the SureLogic license is only available to > committers. For non-committers, I think this may prove to be difficult since > they won't have any local means of checking for warnings and verifying that > they've fixed them. > > Thanks > -Todd > > > 2010/5/5 Konstantin Boudnik <c...@yahoo-inc.com> > >> Hello. >> >> As some of you might know we have the license for great concurrency >> analysis >> software from SureLogic. >> >> SureLogic engineers gave some run for HDFS, MR, and Zookeeper code at the >> end >> of last year. The tools seem very promising and supposedly bring us the >> value (linked from the page below). >> >> Please read this Wiki page to get more information about the tool and to >> get some understanding how it works >> http://wiki.apache.org/hadoop/HowToUseConcurrencyAnalysisTools >> >> Here's the additional information on how to install/upgrade to the latest >> release: http://surelogic.com/static/eclipse/install.html >> >> There's also a couple of JIRAs w/ patches (HDFS-801, MAPREDUCE-1259) to >> integrate annotations into our current source code base. The annotations >> are >> represented as a jar file with some interface classes. They are >> redistributed >> under Apache license. The retention policy of annotations are 'compile >> time', >> i.e. this jar isn't required for the runtime of Hadoop. >> >> It'd be great to hear community thoughts on this so we can make some >> decision >> about this toolset. >> >> Please comment. Thanks >> Cos >> > > > > -- > Todd Lipcon > Software Engineer, Cloudera >
