(zookeeper) branch branch-3.9 updated: ZOOKEEPER-5080: Fix flaky metric assertion in SnapshotAndRestoreCommandTest

[andor]

This is an automated email from the ASF dual-hosted git repository.

asf-gitbox-commits pushed a commit to branch branch-3.9
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/branch-3.9 by this push:
     new d12a2e068 ZOOKEEPER-5080: Fix flaky metric assertion in 
SnapshotAndRestoreCommandTest
d12a2e068 is described below

commit d12a2e0681fb775f7d4c3958ca1a754e891ec23c
Author: xeno <stime...@gmail.com>
AuthorDate: Tue Aug 25 20:21:05 2026 +0200

    ZOOKEEPER-5080: Fix flaky metric assertion in SnapshotAndRestoreCommandTest
    
    Reviewers: uros-b, anmolnar
    Author: IvanKhanas
    Closes #2442 from IvanKhanas/ZOOKEEPER-5080
    
    (cherry picked from commit b1d1f47948de8b4e0de0f8f7e5efb4a311838353)
    Signed-off-by: Andor Molnar <an...@cloudera.com>
---
 .../apache/zookeeper/server/admin/SnapshotAndRestoreCommandTest.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/SnapshotAndRestoreCommandTest.java
 
b/zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/SnapshotAndRestoreCommandTest.java
index 8e189188f..96e60186f 100644
--- 
a/zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/SnapshotAndRestoreCommandTest.java
+++ 
b/zookeeper-server/src/test/java/org/apache/zookeeper/server/admin/SnapshotAndRestoreCommandTest.java
@@ -395,14 +395,14 @@ private void validateSnapshotMetrics() {
         Map<String, Object> metrics = MetricsUtils.currentServerMetrics();
         assertEquals(0, (long) metrics.get("snapshot_error_count"));
         assertEquals(0, (long) metrics.get("snapshot_rate_limited_count"));
-        assertTrue((Double) metrics.get("avg_snapshottime") > 0.0);
+        assertEquals(1L, (long) metrics.get("cnt_snapshottime"));
     }
 
     private void validateRestoreMetrics() {
         Map<String, Object> metrics = MetricsUtils.currentServerMetrics();
         assertEquals(0, (long) metrics.get("restore_error_count"));
         assertEquals(0, (long) metrics.get("restore_rate_limited_count"));
-        assertTrue((Double) metrics.get("avg_restore_time") > 0.0);
+        assertEquals(1L, (long) metrics.get("cnt_restore_time"));
     }
 
     public static  File takeSnapshotAndValidate(final int jettyAdminPort, 
final File dataDir) throws Exception {