(zookeeper) branch master updated: ZOOKEEPER-4848: Fix potential stack overflow in setup_random

[kezhuw]

This is an automated email from the ASF dual-hosted git repository.

kezhuw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zookeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new fe4854a72 ZOOKEEPER-4848: Fix potential stack overflow in setup_random
fe4854a72 is described below

commit fe4854a72a1557a588c25f8251b0681c6be835b3
Author: yarthur1 <30923528+yarth...@users.noreply.github.com>
AuthorDate: Fri Oct 18 09:44:30 2024 +0800

    ZOOKEEPER-4848: Fix potential stack overflow in setup_random
    
    Reviewers: kezhuw, ztzg
    Author: yarthur1
    Closes #2097 from yarthur1/master
---
 zookeeper-client/zookeeper-client-c/src/zookeeper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/zookeeper-client/zookeeper-client-c/src/zookeeper.c 
b/zookeeper-client/zookeeper-client-c/src/zookeeper.c
index a19144b50..97b92dd34 100644
--- a/zookeeper-client/zookeeper-client-c/src/zookeeper.c
+++ b/zookeeper-client/zookeeper-client-c/src/zookeeper.c
@@ -730,7 +730,7 @@ static void setup_random()
             /* Assert we either read something or we were interrupted due to a
              * signal (errno == EINTR) in which case we need to retry.
              */
-            int rc = read(fd, &seed + seed_len, sizeof(seed) - seed_len);
+            int rc = read(fd, (char *)&seed + seed_len, sizeof(seed) - 
seed_len);
             assert(rc > 0 || errno == EINTR);
             if (rc > 0) {
                 seed_len += rc;