teldigi5-wq opened a new pull request, #1975:
URL: https://github.com/apache/wicket/pull/1975

   ## Summary
   
   Fixes #1949
   
   This pull request corrects daylight-saving time (DST) offset detection in 
Apache Wicket's browser information collection.
   
   Previously, `wicket-browser-info.js` assumed that January 1 always 
represented standard time and July 1 always represented daylight-saving time. 
That assumption fails in Southern Hemisphere timezones, where summer occurs 
around January.
   
   ## Changes
   
   - Calculate UTC offsets for January 1 and July 1.
   - Use the smaller UTC offset for standard time (`utcOffset`) and the larger 
offset for daylight-saving time (`utcDSTOffset`), independent of hemisphere.
   - Preserve the behavior of timezones without DST.
   - Add QUnit regression tests for Northern Hemisphere, Southern Hemisphere, 
and fractional-hour DST offsets.
   - Register the new tests with Wicket's JavaScript test suite and lint 
configuration.
   
   ## Regression test coverage
   
   | Timezone | Scenario |
   | --- | --- |
   | `Australia/Sydney` | Southern Hemisphere DST |
   | `America/New_York` | Northern Hemisphere DST |
   | `Asia/Colombo` | No DST |
   | `Australia/Lord_Howe` | 30-minute DST change |
   
   ## Validation
   
   - `npx grunt jshint:core jshint:testsJs` — passed (6 production files and 11 
test files lint-free).
   - `npx grunt connect qunit` — passed:
     - Standard configuration: 219 tests, 0 failed, 0 skipped.
     - Vanilla configuration: 218 tests, 0 failed, 2 skipped.
   - Full Maven test suite not run.
   
   ## Scope
   
   Only browser timezone detection and its JavaScript regression test coverage 
are changed. No dependency upgrades are included.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to