dashorst opened a new pull request, #1933:
URL: https://github.com/apache/wicket/pull/1933
Brings the restyled reference guide from master to the 10.x line (#1931).
Both commits are cherry-picked with `-x`, in order, and keep their master
messages:
1. **Style the reference guide like wicket.apache.org** (745ae018ec, #1845):
Rouge highlighting, the docinfo masthead, the following TOC, language labels
and copy buttons, asides for admonitions, dark mode, no external requests, the
accessibility fixes, and the version line taken from the pom through
build-helper's `parse-version`.
2. **Take the reference guide's fonts from webjars at build time**
(e5999f0896, #1896): the SIL OFL fonts (ASF Category B) come from the
fontsource webjars in the `guide` profile, so they are not in the source tree.
The two commits belong together; the first alone would put the fonts into the
10.x source release.
The only conflict was the title in `single.adoc`: 10.x had `= Wicket 10.x
Reference Guide`. I took master's `= Wicket {wicket_line} Reference Guide`,
which renders as 10.x because the version comes from the pom. The second commit
applied cleanly. No 10.x adaptation was needed. The guide pom now equals
master's apart from the project version and the `asciidoctorj-pdf` (2.3.27) and
`asciidoctorj-diagram` (2.3.2) versions 10.x already had. build-helper is
managed in the root pom, and the pedantic enforcer passes.
The change touches only the guide module, LICENSE (the Asciidoctor
stylesheet entry goes) and `.rat-excludes`. No shipped jar changes.
## Tested
- `mvn clean verify -Pjs-test`: green.
- `mvn -N apache-rat:check`: passes.
- `mvn -pl wicket-user-guide -Pguide generate-resources` builds HTML and
PDF. The title and masthead say 10.x, and the Javadoc link is
https://nightlies.apache.org/wicket/apidocs/10.x/index.html.
- Checked in headless Chromium at 1400px and 390px, light and dark: 519
highlighted listings with labels and copy buttons; all fonts loaded from
`fonts/`; no requests outside the local files; no script errors.
- `git ls-tree -r --name-only HEAD wicket-user-guide | grep -iE
'\.(woff2?|ttf|otf)$'` returns nothing.
## Not included
- #1903 (#1891), #1904 (#1885) and #1929 are not merged on master yet. The
18px sideways scroll at phone width from #1891 is therefore still present here.
- At desktop width the page also scrolls 304px sideways. Asciidoctor's
stylesheet gives `#footer` `width:100%`, and the guide's `margin-left` for the
TOC pushes it past the edge. The CSS is the same on master, so the fix belongs
there first.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]