dashorst commented on PR #1870: URL: https://github.com/apache/wicket/pull/1870#issuecomment-6892685498
Master's build failed after this merge. Three tests in wicket-core-tests build their own `new WicketTester(...)`, so they render with the JVM default locale. On the CI runners that renders `lang="en"`, while the expected files say `lang="en-US"`. The tests are `EnclosureTest.testRenderPage13`, `XForwardedRequestWrapperTest.test7` and `CSPTrustedTypesTest` (from #1880). 89e4f1fb88 switches them to `newWicketTester`, which pins `Locale.US`. That commit went to master directly instead of through a PR. The full build passes locally with the JVM locale set to `en`, and core-tests and extensions also pass under `nl_NL`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
