dashorst commented on code in PR #1691:
URL: https://github.com/apache/wicket/pull/1691#discussion_r4564177273
##########
archetypes/quickstart/src/main/resources/archetype-resources/pom.xml:
##########
@@ -183,6 +184,7 @@
<systemProperties>
<maven.project.build.directory.test-classes>${project.build.directory}/test-classes</maven.project.build.directory.test-classes>
</systemProperties>
+ <useTestScope>true</useTestScope>
Review Comment:
Agreed, and done. I reproduced it on a quickstart generated from 11.0.0:
`useTestScope` gave 84 "scanned from multiple locations" warnings, while
compile scope with `packagingExcludes` logs without warnings and leaves
`slf4j-simple` out of both the WAR and the exploded webapp.
Both PRs now take that approach. On 10.x the scope stays as it was and the
cherry-pick of #1684 is gone, so that PR is a single commit with the exclusion.
The backport to wicket-11.x is #1898.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]