dashorst opened a new pull request, #1898:
URL: https://github.com/apache/wicket/pull/1898

   Backport of #1691 to `wicket-11.x`, for GitHub issue #1690. 11.0.0 shipped 
with #1684, so `mvn jetty:run` on a quickstart generated from 11.0.0 has no 
SLF4J back end and logs nothing.
   
   `slf4j-simple` is back at compile scope and the maven-war-plugin leaves it 
out of the WAR, so `Start`, `jetty:run` and the tests log while the WAR carries 
no back end. Cherry-picked from #1691 with `-x`; see that PR for the reasoning.
   
   Verified on this branch:
   - `mvn verify -pl archetypes/quickstart` passes, including the archetype 
integration test.
   - `mvn jetty:run` on the generated project logs `Started Wicket version 
11.1.0-SNAPSHOT in DEVELOPMENT mode`, prints no warnings, and `/` returns 200.
   - The WAR and the exploded webapp contain `slf4j-api` and no back end.
   
   Release-note wording: `mvn jetty:run` on a quickstart generated from 11.0.0 
logs nothing, because `slf4j-simple` has test scope there. Projects generated 
from 11.1.0 on keep it at compile scope and exclude it from the WAR. To fix an 
11.0.0 quickstart, remove `<scope>test</scope>` from `slf4j-simple` and add 
`<packagingExcludes>WEB-INF/lib/slf4j-simple-*.jar</packagingExcludes>` to the 
maven-war-plugin configuration.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to