reiern70 opened a new pull request, #1893:
URL: https://github.com/apache/wicket/pull/1893

   Backport of #1890 to `wicket-10.x`, for GitHub issue #1886.
   
   Stacked on #1889, the 10.x backport of #1887. Its base is 
`email-pattern-1884-10.x`, so the diff shows only this fix. Merge #1889 first; 
GitHub then retargets this PR to `wicket-10.x`.
   
   - 2a8ff915c4, cherry-picked from #1890 and adapted: a reversed 
`PatternValidator` renders no `pattern` attribute from `HTML5Attributes`.
   - On 10.x, `AbstractTextComponent` does not render the attribute itself, so 
its hunk is dropped. The bug shows only with `HTML5Attributes`. `TextFieldTest` 
checks both the rendered pattern and the reversed case through that behavior, 
and the javadoc and the commit message are adapted to match.
   - `PatternValidator#isReverse()` is new, `@since 10.13.0`.
   
   The only API change is the added method, a binary-compatible change; japicmp 
passes against 10.0.0. Applications have nothing to migrate.
   
   Verified on this branch:
   - `TextFieldTest` passes. The reversed case fails without the fix.
   - `mvn clean verify -Pjs-test` is green, japicmp included.
   
   This goes in after #1890. If #1890 changes in review, this branch gets the 
same change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to