dashorst commented on code in PR #1869: URL: https://github.com/apache/wicket/pull/1869#discussion_r4537685200
########## AGENTS.md: ########## @@ -101,10 +104,10 @@ header — copy it when you add one. - Quiet is not permission. Changing or removing public API on `master` is allowed but not free: it needs a justification in the commit message, and where the old member can survive next to the new one, deprecate it rather than remove it. -- An API change owes users a migration path. Add an OpenRewrite recipe to +- A change that breaks or changes an existing application owes users a migration path: an entry + in `migration-to-<major>.md` in the root of the branch, and an OpenRewrite recipe in `wicket-migration/src/main/resources/META-INF/rewrite/wicket.yml` where the change is - mechanical, and draft the migration-guide wording in the commit message or the pull request - description — the guide itself lives on the wiki, where only a human can put it. + mechanical, both in the same commit. Review Comment: I'd rather have each in their respective branches than a long list of migration guides in our main branch, which is the current status AFAIK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
