dashorst opened a new pull request, #1872: URL: https://github.com/apache/wicket/pull/1872
The same change as #1871, for `wicket-11.x`: Spotless checks the Java code format in every module during the build, using the same profile `codestyle/wicket-formatter.xml` and the same formatter version (Spotless 3.10.4, Eclipse JDT 4.41). #1871 explains how the profile was derived and what to know about line endings, IDEs and open pull requests. **Merge this PR with "Create a merge commit", not squash or rebase.** `.git-blame-ignore-revs` lists the reformat commit by hash. ## Why the maintenance line is reformatted too Fixes go from `master` to the maintenance lines by cherry-pick, and git merges text lines without knowing about formatting. With only `master` reformatted, any fix touching a reformatted region would conflict. The formatter is deterministic, so with the same profile and version on every line, identical code comes out identical: all 3398 Java files that were identical between `master` and `wicket-11.x` before the reformat are still identical after it. Cherry-picks stay as clean as they are today. That only holds while every line uses the same profile and formatter version. A later change to either has to land on all three lines. ## Commits 1. **Reformat the Java sources with the Wicket formatter profile.** 1196 files, +12.4k/−10.5k lines, whitespace only. With all whitespace removed every file is identical to before, and string literals and text blocks are unchanged. 2. **Check the Java code format in the build with Spotless.** The pom changes are identical to #1871's; the profile, `.editorconfig` and README section are the same files. ## Verification - `mvn clean verify -Pjs-test` passes on the reformatted tree (JDK 21). Part of #1867 Generated-by: Claude Code (Claude Opus 5.5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
