dashorst opened a new pull request, #1847: URL: https://github.com/apache/wicket/pull/1847
Adds chapter 25, Accessibility, to the user guide. It sits after the testing chapters and before the best practices, so forms (11–12), repeaters (13), i18n (15), AJAX (19) and WicketTester (23) have all been introduced by then. The chapter targets WCAG 2.2 level A and AA. It has a table of all 55 success criteria, each with the Wicket mechanism, the application's part and a link to the code. The other sections cover an accessible base page (lang from the session locale, a title per page, a skip link, landmarks, error pages), form errors (`wicket:for`, `aria-invalid`/`aria-describedby`), focus and announcements after AJAX updates, keyboard-operable AJAX controls, and data tables (caption, row headers, `aria-sort`, stable sort-link ids). A final section covers validating an application: WicketTester/TagTester assertions, axe-core with Playwright, HTML validation and the manual checks. Where Wicket has no support yet, the chapter shows a workaround with the current API. Those gaps are input for #1838. The full-page `<html>` examples elsewhere in the guide get `lang="en"`. The layout chapter's base page gets a title label, `lang`, a skip link and landmark elements. The internals chapter reference moves from 26 to 27. ## Review notes - **Core:** `accessibility/accessibility_2.adoc` (the criteria table) and `accessibility_4`, `_5`, `_7` (the code-heavy sections). - **Mechanical:** the `lang="en"` additions in the other chapters, and the chapter number in `versioningCaching_2.adoc`. - **Verification:** the Java and HTML examples were compiled and run in a scratch project against master's 11.0.0-SNAPSHOT. Four WicketTester tests pass, and the rendering checks for dialog roles, `aria-sort`, `<th scope="row">` and the paging links pass. The axe-core/Playwright example compiles but has not been run against a live application. The guide builds with `mvn -pl wicket-user-guide -Pguide package`, and the new chapter has no broken anchors. - **Open:** the keyboard section discourages `AjaxLink` on `<a href="#">` for actions. That is guidance, not a WCAG failure. Closes #1839 Generated-by: Claude Code (Claude Opus 5.5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
