papegaaij opened a new pull request, #1833:
URL: https://github.com/apache/wicket/pull/1833

   The resources-optimizer-maven-plugin reads its input from `target/classes`, 
the same directory it writes its `.min.js` and `.min.css` files to, and only 
`jquery*.js` was excluded. A build without `clean` therefore minified the 
previous run's `.min` files again, into `*.min.min.*`:
   
   - `wicket-extensions` failed with `JSC_NON_CONST_DEFINE`. The minified 
`wicket-veil.js` contains the `$jscomp` polyfills Closure injects for 
`for...of`, and compiling them again redefines their `@define` constants.
   - Modules that got past the optimizer packaged the doubled files. The 
`wicket-core` jar carried nine of them.
   
   The optimizer now also excludes `**/*.min.js` and `**/*.min.css`.
   
   ### Testing
   
   `mvn clean install -DskipTests -Pfast` followed by `mvn install -DskipTests 
-Pfast` over the full reactor:
   
   - Both builds succeed. Before this change the second one failed in 
`wicket-extensions`.
   - Both runs minify the same 26 files and produce the same 29 `.min` files in 
`target/classes`, the three pre-minified jQuery files included. No 
`*.min.min.*` files are created.
   
   Applications see no difference, because released jars are built from a clean 
tree.
   
   Fixes #1832
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to