This is an automated email from the ASF dual-hosted git repository.
bitstorm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/wicket.git
The following commit(s) were added to refs/heads/master by this push:
new 4492cdede7 Return the text before the last occurrence from
StringValue.beforeLast (#1725)
4492cdede7 is described below
commit 4492cdede72dc768fad771f51fe270487332f09b
Author: Nexory <[email protected]>
AuthorDate: Wed Nov 4 09:29:10 2026 +0100
Return the text before the last occurrence from StringValue.beforeLast
(#1725)
StringValue.beforeLast(char) delegated to Strings.afterLast instead of
Strings.beforeLast. It returned the text after the last occurrence of the
character, where its Javadoc, the class documentation and the static
Strings.beforeLast say it returns the text before it: for "bar:baz:foo" and
':' it gave "foo" instead of "bar:baz".
It now delegates to Strings.beforeLast, which gives "bar:baz" for that value
and an empty string when the character does not occur, as beforeFirst does.
Nothing in Wicket calls the method. An application that called it got the
text after the last occurrence and now gets the text before it; one that
relied on the old result has to call afterLast.
The tests cover beforeLast and, next to it, beforeFirst, afterFirst and
afterLast, which had none.
Generated-by: Claude Code
---
.../org/apache/wicket/util/string/StringValue.java | 2 +-
.../apache/wicket/util/string/StringValueTest.java | 28 ++++++++++++++++++++++
2 files changed, 29 insertions(+), 1 deletion(-)
diff --git
a/wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java
b/wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java
index 7e991c2179..88f5d51b27 100755
--- a/wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java
@@ -283,7 +283,7 @@ public class StringValue implements IClusterable
*/
public final String beforeLast(final char c)
{
- return Strings.afterLast(text, c);
+ return Strings.beforeLast(text, c);
}
/**
diff --git
a/wicket-util/src/test/java/org/apache/wicket/util/string/StringValueTest.java
b/wicket-util/src/test/java/org/apache/wicket/util/string/StringValueTest.java
index 0b4f485897..02f572c6d3 100644
---
a/wicket-util/src/test/java/org/apache/wicket/util/string/StringValueTest.java
+++
b/wicket-util/src/test/java/org/apache/wicket/util/string/StringValueTest.java
@@ -162,6 +162,34 @@ public class StringValueTest
}
+ @Test
+ public void beforeLast()
+ {
+ assertEquals("bar:baz",
StringValue.valueOf("bar:baz:foo").beforeLast(':'));
+ assertEquals("", StringValue.valueOf("bar").beforeLast(':'));
+ }
+
+ @Test
+ public void beforeFirst()
+ {
+ assertEquals("bar",
StringValue.valueOf("bar:baz:foo").beforeFirst(':'));
+ assertEquals("", StringValue.valueOf("bar").beforeFirst(':'));
+ }
+
+ @Test
+ public void afterFirst()
+ {
+ assertEquals("baz:foo",
StringValue.valueOf("bar:baz:foo").afterFirst(':'));
+ assertEquals("", StringValue.valueOf("bar").afterFirst(':'));
+ }
+
+ @Test
+ public void afterLast()
+ {
+ assertEquals("foo",
StringValue.valueOf("bar:baz:foo").afterLast(':'));
+ assertEquals("", StringValue.valueOf("bar").afterLast(':'));
+ }
+
static enum TestEnum {
FOO, BAR, BAZ
}