dashorst opened a new pull request, #1751:
URL: https://github.com/apache/wicket/pull/1751

   Backport of #1750 to `wicket-10.x`, plus one 10.x-only change to the 
announcement template. GitHub issue #1749.
   
   ## Summary
   
   Cherry-picked from #1750 (`git cherry-pick -x`, no conflicts; the only 
difference between the two `release.sh` versions is `GIT_BRANCH=wicket-10.x`):
   
   - Take the staging repository from the repositories that the deploy created, 
by comparing `rc-list` before `release:prepare` and after `release:perform`, 
instead of taking every `orgapachewicket-*` in the list that is not `CLOSED`. 
Stop with a message unless exactly one was created. A failed `rc-list` or 
`rc-close` is now fatal. 10.x deploys through the Apache parent pom with 
implicit staging as well, so the same reasoning applies.
   - Write the release changelog to a new `mktemp` file on every run, so a 
rerun no longer puts it twice into `release-vote.txt` and 
`release-announce.txt`.
   - Add `set -e` to the generated revert and promote scripts so they stop at 
the first failing step. The revert script's listing reads `tail -n +15`; `rm -f 
release.properties` replaces the `[ -f ] && rm` line.
   - `fail` prints its message with `printf`, so the error colour is an escape 
sequence and not literal text.
   - The script templates are read with `read -r`, and the promote script's 
`svn rm` quotes are escaped once, so the commands it prints can be copied as 
they are.
   
   10.x only:
   
   - The announce mail gets a "New and noteworthy" section saying that Wicket 
10 is the LTS version until Wicket 14, with a link to the release cadence post, 
as added by hand to the 10.12.0 announcement. The generated site post is titled 
"Apache Wicket <version> (LTS) is released" and has a matching description.
   
   ## Testing
   
   Nothing was run against Nexus, dist.apache.org or a git remote. The testing 
of #1750 applies to the cherry-picked commits; on this branch:
   
   - `bash -n release.sh` passes.
   - Stubbed run with stub `mvn`, `git` and `svn` on the PATH: the generated 
`revert-<version>.sh` and `promote-<version>.sh` start with `set -e`, keep 
their listing offsets (15 and 14) and check out `wicket-10.x`.
   - `generate_signatures_from_release`, `generate_announce_email` and 
`generate_announce_md` for a fake 10.13.0: `release-announce.txt` and 
`wicket-10.13.0-released.md` contain the LTS section with the link, and the 
site post's front matter has the (LTS) title and the description.
   - Not run: a full `release.sh` run, and `mvn clean verify`, as the change 
touches only `release.sh`.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to