papegaaij opened a new pull request, #1731:
URL: https://github.com/apache/wicket/pull/1731

   Fixes #1723
   
   The source release bundles third-party code that the top-level `LICENSE` 
never mentioned. `NOTICE` was assembled at release time from every module's 
`META-INF/NOTICE` and was mostly attribution no license requires. This PR 
rebuilds both following the [ASF licensing 
how-to](https://infra.apache.org/licensing-howto.html).
   
   ## What changes
   
   - **`LICENSE`**: the complete Apache License text. The old file stopped 
after section 9, which the Apache Trusted Releases platform's line-by-line 
comparison would reject. After it comes a section naming each bundled 
third-party component, with its version, location and license.
   - **`licenses/`**: the license texts that `LICENSE` points to.
     - Added: jQuery/OpenJS (MIT), Mockjax, Blanket.js 1.1.5, falafel, 
Prototype, Dojo (BSD), W3C, Asciidoctor.
     - Removed: the unreferenced ASM, JUnit, SLF4J and Yahoo texts.
   - **`NOTICE`**: only the ASF notice. The JRCS diff code is ASF code under 
ASL 1.1, and the standard ASF line is the acknowledgement that license asks for.
   - **wicket-core and wicket-util jars**: a `META-INF/LICENSE` that adds the 
third-party code bundled in that jar, with the full license texts.
     - wicket-core: jQuery 3.7.1 and 4.0.0, jQuery Migrate 4.0.2, MultiSelector.
     - wicket-util: JRCS under ASL 1.1, the XHTML DTDs under the W3C license.
   - **Module NOTICE files**: the hand-written ones (core, guice, tester, 
metrics) are removed, so those jars get the generated NOTICE with the current 
year. They said 2006-2023 and listed dependencies that aren't bundled.
   - **`LICENSE-binary`**: the binary release's `LICENSE`, covering what its 
jars bundle. `release.sh` previously copied the source `LICENSE` there.
   - **`release.sh`**: no longer concatenates NOTICE files; it only updates the 
copyright year.
   
   ## Needs a human eye
   
   These are judgement calls I could not settle from the files alone:
   
   - **Behaviour 1.1** (`examples/preview/behaviour.js`) says only "entirely 
BSD licensed", with no license text. `LICENSE` quotes that statement instead of 
inventing a BSD text.
   - **MultiSelector** (`MultiFileUploadField.js`) is under "use this 
however/wherever you like" terms, not a recognised license. `LICENSE` quotes 
the terms. Whether that is acceptable may be a legal-discuss question.
   - **SIL OFL fonts**: OFL is Category B, which may be included in binary form 
only. The `.woff`/`.ttf`/`.eot` files are binary, but the `.svg` font variants 
in `wicket-examples` are text.
   - **falafel** (inside `blanket.min.js`) has no LICENSE file upstream any 
more. Its text in `licenses/` is the MIT license with the copyright line from 
the bundled header.
   - **Blanket.js**: upstream added a use restriction to its LICENSE in 2020, 
which would make it Category X. The bundled 1.1.5 predates that, and its 
`LICENSE-MIT` at the `v1.1.5` tag is plain MIT; that is the text used here.
   - **Dojo 0.2.2** is dual AFL/BSD. The BSD text is Dojo's own, with the 
copyright line from the bundled file.
   - **XHTML DTDs**: they match W3C's originals apart from CVS keywords, so the 
change-notice condition of the W3C license does not apply.
   
   ## Not covered
   
   - **The examples war** is deployed to Maven Central with about 60 
third-party jars in `WEB-INF/lib`. Its LICENSE/NOTICE do not cover them. That 
is a separate decision: document all the jars, or stop deploying the war.
   - **Sources jars carry no NOTICE.** The generated NOTICE never reaches them. 
wicket-core's sources jar used to get the hand-written one; the other modules 
never had one.
   - **Image provenance**: images such as the tree theme icons in 
wicket-extensions can't be traced from the repository. Neither RAT nor the ATR 
checks them.
   
   ## Verification
   
   - `mvn clean verify -Pjs-test` passes.
   - The built jars have the expected `META-INF/LICENSE` and `META-INF/NOTICE`.
   - RAT 0.18, run with the ATR's arguments on a `git archive`, finds no 
third-party license that `LICENSE` doesn't list. The RAT check itself is the 
follow-up PR.
   
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to