dashorst commented on PR #1722:
URL: https://github.com/apache/wicket/pull/1722#issuecomment-6466369258

   @reiern70 thanks for the review. All four suggestions are in, together with 
the master question:
   
   - **Master:** #1726 carries the same three commits against master and goes 
in first; this PR follows as its 10.x counterpart. The releases staged before 
this fix have been withdrawn, so they will be restaged with it.
   - **1. One check:** `isInJavaPackage` is now used by the naming strategy, 
`resolveLoadingStrategy` and `resolveClassLoader(Class)`.
   - **2. The null fallback:** removed in 76935f9795. A bootstrap type outside 
`java.*` still fails with the existing "package is not open" message.
   - **3. Javadoc:** both are one line now; the reasoning moves to the commit 
message.
   - **4. Subject and description:** both PRs are squashed on merge with your 
suggested subject and a body that references WICKET-7204. The description here 
has been rewritten.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to