Nexory opened a new pull request, #1725:
URL: https://github.com/apache/wicket/pull/1725
`StringValue.beforeLast(char)` called `Strings.afterLast` instead of
`Strings.beforeLast`, so `StringValue.valueOf("bar:baz:foo").beforeLast(':')`
returned `foo` instead of `bar:baz`.
It now calls `Strings.beforeLast`, as its Javadoc says. Nothing in Wicket
calls the method.
`StringValueTest` gets a test for `beforeLast`, which fails without the
change. `beforeFirst`, `afterFirst` and `afterLast` get tests too, since they
had none.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]