AliRana30 commented on PR #806: URL: https://github.com/apache/wayang/pull/806#issuecomment-6297310619
Thanks for the review @novatechflow ! Both issues are fixed and tested on Java 17: 1. User settings preserved: `MachineLearning.setProperties` now applies a default only if the user hasn't already set it. This covers encode-ids, the model path, experience collection and reoptimization. 2. Shorthand fixed: wayang.ml.encode-ids=true is no longer shadowed by the default canonical false. 3. Tests: Added regression tests in TreeEncoderTest for plugin registration and shorthand resolution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
