novatechflow commented on PR #839: URL: https://github.com/apache/wayang/pull/839#issuecomment-6261890746
Thanks for the contribution. Pls always add regression tests. - Quoting changes identifier case handling. On HSQLDB, an existing unquoted `target_append` becomes `TARGET_APPEND`, but the new SQL targets `"target_append"`. Append fails, and overwrite leaves the original table untouched. - The shared validation rejects valid BigQuery names such as `my-project.sales.orders`, including the documented backtick-quoted form. Reproduced both with focused Java 17 checks. Preserve identifier lookup semantics & handle dialect-specific names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
