Cole-Greer commented on code in PR #3472:
URL: https://github.com/apache/tinkerpop/pull/3472#discussion_r3469980336
##########
gremlin-js/gremlin-javascript/lib/driver/connection.ts:
##########
@@ -99,10 +163,39 @@ export default class Connection extends EventEmitter {
throw new TypeError('interceptors must be a function, array, or
undefined');
}
+ // The deprecated `headers` option is implemented as a synthesized
interceptor so custom
+ // headers still work without re-introducing dead configuration. It is
appended after user
Review Comment:
It may be preferable to push the headers interceptor before the users
interceptors, it would prevent us from worrying about any changes to the
request message format made by the users custom interceptors, and it also would
ensure that the new headers are visible from within the users interceptors in
case they need them for any purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
