kenhuuu commented on code in PR #3468:
URL: https://github.com/apache/tinkerpop/pull/3468#discussion_r3453562000
##########
gremlin-dotnet/src/Gremlin.Net/Driver/ConnectionSettings.cs:
##########
@@ -85,10 +106,107 @@ public class ConnectionSettings
/// </summary>
public bool BulkResults { get; set; } = false;
+ /// <summary>
+ /// Gets or sets the default batch size that fills the per-request
batch size when it
+ /// is not set on the request (client-side default-filling; no
wire change).
+ /// </summary>
+ public int DefaultBatchSize { get; set; } = DefaultBatchSizeValue;
+
+ /// <summary>
+ /// Gets or sets the SSL/TLS options used for HTTPS connections
(client certificates,
+ /// custom CA, protocols, etc.). When set, these options are used
to configure the
+ /// underlying handler. <see cref="SkipCertificateValidation"/> is
applied to an
+ /// internal copy of these options rather than mutating the object
provided here.
+ /// </summary>
+ public SslClientAuthenticationOptions? Ssl { get; set; }
+
/// <summary>
/// Gets or sets whether to skip SSL certificate validation.
- /// Only use for testing with self-signed certificates.
+ /// Only use for testing with self-signed certificates. When <see
cref="Ssl"/> is also
+ /// provided, the accept-all callback is set on an internal copy
of those options so the
+ /// caller's <see cref="SslClientAuthenticationOptions"/> instance
is never mutated
+ /// (which is important when one instance is shared across
multiple clients).
/// </summary>
public bool SkipCertificateValidation { get; set; } = false;
+
+ /// <summary>
+ /// Gets or sets the maximum allowed size, in bytes, of the
response headers.
+ /// A value of <c>0</c> (the default) leaves the handler default
unchanged. The native
+ /// handler unit is kilobytes; the byte value provided here is
converted internally.
+ /// </summary>
+ public int MaxResponseHeaderBytes { get; set; } = 0;
+
+ /// <summary>
+ /// Gets or sets the idle-read timeout applied to each individual
read of the response
+ /// stream. It resets per chunk, so it is an idle-read timeout
rather than a
+ /// whole-request deadline. <see
cref="System.Threading.Timeout.InfiniteTimeSpan"/>
+ /// (the default) disables it.
+ /// </summary>
+ public TimeSpan ReadTimeout { get; set; } =
System.Threading.Timeout.InfiniteTimeSpan;
+
+ /// <summary>
+ /// Gets or sets the HTTP proxy used for connections. When set, it
is applied to the
+ /// underlying handler explicitly.
+ /// </summary>
+ public IWebProxy? Proxy { get; set; }
Review Comment:
Maybe too specific to the HttpClient? It seems like some other GLVs create
specific options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
