spmallette commented on code in PR #3458: URL: https://github.com/apache/tinkerpop/pull/3458#discussion_r3424053408
########## docs/src/upgrade/release-4.x.x.asciidoc: ########## @@ -100,6 +69,32 @@ GLVs (including the Java driver). This aligns with the embedded graph transactio partial work is discarded if the user forgets to call `commit()`. In Java (both remote and embedded mode), the behavior can still be overridden via `tx.onClose(Transaction.CLOSE_BEHAVIOR.COMMIT)`. The non-Java GLVs do not support configuring close behavior and always rollback. +==== Traversal-Accepting Steps + +Steps and predicates that previously only accepted literal values now accept child traversals resolved per-traverser Review Comment: Folks have been waiting on this feature for a long time. It needs a strong introduction with some history about the challenges folks had with the old way to do some of this stuff. Show some comparisons demonstrating the old way versus the ease of the new way. Stuff like the following is instructional details and doesn't really belong here: > Child traversals take only the first result (consistent with `by(traversal)` semantics). For `within()`/`without()`, use `fold()` to collect multiple values into a list. i think we should also be telling users in this section what patterns this feature allows them to replace to make their code perform better, read better, etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
