Cole-Greer commented on code in PR #3447:
URL: https://github.com/apache/tinkerpop/pull/3447#discussion_r3391913134
##########
gremlin-python/src/main/python/gremlin_python/driver/connection.py:
##########
@@ -34,17 +35,23 @@ def __init__(self, status):
class Connection:
def __init__(self, url, traversal_source,
- executor, pool, request_serializer=None,
+ executor, pool,
response_serializer=None, auth=None, interceptors=None,
headers=None, enable_user_agent_on_connect=True,
bulk_results=False, **transport_kwargs):
if callable(interceptors):
interceptors = [interceptors]
- elif not (isinstance(interceptors, tuple)
- or isinstance(interceptors, list)
- or interceptors is None):
+ elif isinstance(interceptors, tuple):
+ interceptors = list(interceptors)
+ elif not (isinstance(interceptors, list) or interceptors is None):
raise TypeError("interceptors must be a callable, tuple, list or
None")
+ # Auth is just an interceptor. As a convenience (and for
discoverability), the auth
Review Comment:
Python is the only GLV which maintains a separate config for `auth` beyond
the general `interceptor` configuration option. I think this is a good
opportunity to simplify things and bring python inline with the other GLVs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
