Cole-Greer commented on code in PR #3448:
URL: https://github.com/apache/tinkerpop/pull/3448#discussion_r3365761386
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/util/Tree.java:
##########
@@ -20,125 +20,249 @@
import java.io.Serializable;
import java.util.ArrayList;
-import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
/**
+ * A tree data structure with a tree-shaped public API that is composed of a
{@link HashMap}.
+ * <p>
+ * Internal storage is a plain {@link HashMap}, so iteration order is not
promised and sibling-key collisions still
Review Comment:
To add a bit more to that, collapsing of sibling-key collisions is described
as a bug or limitation when according to TINKERPOP-1693 it is expected/intended
behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
