Cole-Greer commented on PR #3434: URL: https://github.com/apache/tinkerpop/pull/3434#issuecomment-4635974615
One extra thing to note, this PR deletes a lot of the old commented out/skipped transaction tests in favour of a fresh set of tests. I'm fine with that change but I was comparing the old and new tests and found a few minor gaps: First of all there are still some old skipped transaction tests in python which have not been cleaned up here: https://github.com/apache/tinkerpop/blob/7c2cd79a9f4f184ea15ed8b0a5a62d7acef82348/gremlin-python/src/main/python/tests/integration/process/test_traversal.py#L95 Also the old Python and Go transaction tests seemed to have been a bit richer than the other GLVs, and contain a few cases which are not replicated in the new tests: | Old scenario | Go old test | Python old test | In new tests? | |---|---|---|---| | Two concurrent txns, both rolled back, graph unchanged | Test multi rollback Transaction | test_multi_rollback_transaction | ❌ No | | Two concurrent txns, one commits + one rolls back, only committed data persists | Test multi commit and rollback Transaction | test_multi_commit_and_rollback | ❌ No | | Close from parent: closing the parent DriverRemoteConnection closes/rolls back child txns | Test Transaction close tx from parent | test_transaction_close_tx_from_parent | ❌ No | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
